Looks good.
OS is documented as a user-settable variable (to override cases where automatic
detection fails), so should be DOWNWARD_OS.
The starting point for all this was that people wanted to override some
variables like CXX and DEPEND to build Fast Downward with a non-system C++
compiler. Maybe we should permit setting these via the environment, too, for
consistency. I think we could simply achieve this by not setting CXX at all
(since there should be a built-in Make variable by that name that defaults to
g++) and by defining DEPEND in terms of CXX rather than setting it directly.
(I don't think having variables like DOWNWARD_CXX etc. for these would be a good
idea; it goes against common Linux practice.)
|