Issue485

Title searches not using the options class for open_list
Priority wish Status resolved
Superseder Nosy List gabi, jendrik, malte, pvonreth
Assigned To Keywords
Optional summary

Created on 2014-10-06.12:39:06 by pvonreth, last changed by jendrik.

Messages
msg3916 (view) Author: jendrik Date: 2014-12-12.15:27:19
Allowing only Options objects in OpenList constructors means lots of code changes 
and lots of additional code, since for each constructor call we have to create 
and populate an Options object. Also, there's currently no real reason why we 
need to require Options objects. Therefore, I'm closing this issue for now.
msg3691 (view) Author: pvonreth Date: 2014-10-07.12:58:10
That changed as we now pass the local open list as an argument to the search. 
And we only need the options being available in the search engine to be able to 
create a local search and there the options are used.
But since I don't create new open lists any more it is not important there 
anymore.
msg3689 (view) Author: jendrik Date: 2014-10-07.11:45:48
I think this is still important since currently we can only use eager() and 
lazy() for local exploration searches (issue466) and neither eager_greedy() nor 
lazy_greedy() since these create open lists without passing any Options objects.
msg3686 (view) Author: pvonreth Date: 2014-10-07.11:22:25
With the latest changes to issue466 this is of no concern regarding my im
implementation.

But it still could be a possibility to simplify the construction of open lists.
msg3677 (view) Author: pvonreth Date: 2014-10-06.14:52:40
In both cases 
StandardScalarOpenList<OpenListEntryLazy>(evals[0],false); is used and no o
options are passed to the open list.
That's the reason we have to maintain this constructor besides StandardScalarOpenList
StandardScalarOpenList(const Options &opts);

In my implementation for local search I store a copy of the options inside the op
open list, to be able to create a new instance of the open list based on the sa
same options. But I can also modify those options before I create a new in
instance.
But if the open list was created without options at all this will fail.
Tho I think it would make sense, not only for my branch but also in general, to 
change the way the open lists are created there.
msg3674 (view) Author: gabi Date: 2014-10-06.13:42:44
What is exactly the issue here? What do we currently have to do what we want to
avoid?
msg3673 (view) Author: pvonreth Date: 2014-10-06.12:39:06
Some searches still don't use the options class that results in the need of 
additional constructors for OpenLists.
Also issue466 is heavily based on the use of options to create new open lists 
with the same settings, which is impossible in some cases due to the creation 
of the open_lists without the Options class.
History
Date User Action Args
2014-12-12 15:27:19jendriksetstatus: chatting -> resolved
messages: + msg3916
2014-10-07 12:58:10pvonrethsetmessages: + msg3691
2014-10-07 11:45:49jendriksetmessages: + msg3689
2014-10-07 11:22:25pvonrethsetmessages: + msg3686
2014-10-06 14:52:40pvonrethsetmessages: + msg3677
2014-10-06 13:42:44gabisetnosy: + gabi
messages: + msg3674
2014-10-06 12:39:06pvonrethcreate