Issue491

Title M&S refactoring: get rid of unused labels rather than having a tree-like structure
Priority wish Status resolved
Superseder Nosy List malte, silvan
Assigned To silvan Keywords
Optional summary

Created on 2014-10-15.18:02:59 by silvan, last changed by silvan.

Messages
msg3865 (view) Author: silvan Date: 2014-10-23.16:39:57
Marking this one as resolved.
msg3864 (view) Author: silvan Date: 2014-10-23.16:36:33
Just for the record: I did some experiments just to make sure I did not mess
anything up with the last few changes.
http://ai.cs.unibas.ch/_tmp_files/sieverss/2014-10-22-issue491-v4-cggl-comp.html
http://ai.cs.unibas.ch/_tmp_files/sieverss/2014-10-22-issue491-v4-dfp-comp.html
http://ai.cs.unibas.ch/_tmp_files/sieverss/2014-10-22-issue491-v4-rl-comp.html
msg3857 (view) Author: silvan Date: 2014-10-22.15:39:23
Thanks! I'll fix the small things you mentioned and will merge (back on the way
home :-) ).
msg3856 (view) Author: malte Date: 2014-10-22.15:36:35
I looked at the code and made all the comments I have. It's only a few small
things; otherwise, looks ready to merge for me. :-)
msg3855 (view) Author: malte Date: 2014-10-22.15:13:41
Right, results look good. :-) I'll have a look at the code next.
msg3854 (view) Author: silvan Date: 2014-10-22.15:08:23
I think this was the mixture of bad luck (some run logs I compared showed no
difference in behavior other than time/memory comsumption which I could not see
any reason for) and a bug which only affected tasks detected as unsolvable by
the translator (empty g_operators).

http://ai.cs.unibas.ch/_tmp_files/sieverss/2014-10-21-issue491-v3-cggl-comp.html
http://ai.cs.unibas.ch/_tmp_files/sieverss/2014-10-21-issue491-v3-dfp-comp.html
http://ai.cs.unibas.ch/_tmp_files/sieverss/2014-10-21-issue491-v3-rl-comp.html
msg3850 (view) Author: silvan Date: 2014-10-20.15:31:39
You are right, actually nothing should have changed with the last commit.

The diff is here:
https://bitbucket.org/SilvanS/fd-dev/commits/777cd54388d30258f047578c80f4f22bced5e309
msg3848 (view) Author: malte Date: 2014-10-20.14:02:52
I don't think they looks so good. In the previous version, the time scores were
fine (mostly green), now they look quite a bit red. Do you have an idea where
this comes from? Is it possible to prepare a diff between v1 and v2 for
commenting on?
msg3847 (view) Author: silvan Date: 2014-10-20.08:47:36
I did more refactorings (see pull request) and compared against the previous
version (looks all good):
http://ai.cs.unibas.ch/_tmp_files/sieverss/2014-10-19-issue491-v2-cggl-comp.html
http://ai.cs.unibas.ch/_tmp_files/sieverss/2014-10-19-issue491-v2-dfp-comp.html
http://ai.cs.unibas.ch/_tmp_files/sieverss/2014-10-19-issue491-v2-rl-comp.html
msg3841 (view) Author: silvan Date: 2014-10-17.11:03:05
I created a pull request.
msg3840 (view) Author: malte Date: 2014-10-17.11:00:31
The design sounds good to me for now. Can you send a link to the code?
msg3839 (view) Author: silvan Date: 2014-10-17.07:51:40
http://ai.cs.unibas.ch/_tmp_files/sieverss/2014-10-16-issue491-v1-cggl-comp.html
http://ai.cs.unibas.ch/_tmp_files/sieverss/2014-10-16-issue491-v1-dfp-comp.html
http://ai.cs.unibas.ch/_tmp_files/sieverss/2014-10-16-issue491-v1-rl-comp.html

Results look rather fine I think, gaining a bit in several configurations.

Should we discuss a more advanced design of handling non-existing labels or is
that fine for the moment?
msg3838 (view) Author: silvan Date: 2014-10-16.21:08:07
Experiments for the first version are running.

I simply removed the tree structure, deleting all reduced labels, setting the
entries in the vector of all labels to 0, similar to how the set of all
transition systems is handled in the merge-and-shrink heuristic.
msg3829 (view) Author: silvan Date: 2014-10-15.18:02:59
This is part of meta issue432 (item 2 in msg3681).

Get rid of unused labels rather than having a tree-like structure for the set
of all labels. This should be possible under the assumption that abstractions
are always in a valid state.
History
Date User Action Args
2014-10-23 16:39:57silvansetstatus: chatting -> resolved
messages: + msg3865
2014-10-23 16:36:33silvansetmessages: + msg3864
2014-10-22 15:39:23silvansetmessages: + msg3857
2014-10-22 15:36:35maltesetmessages: + msg3856
2014-10-22 15:13:41maltesetmessages: + msg3855
2014-10-22 15:08:23silvansetmessages: + msg3854
2014-10-20 15:31:39silvansetmessages: + msg3850
2014-10-20 14:02:52maltesetmessages: + msg3848
2014-10-20 08:47:37silvansetmessages: + msg3847
2014-10-17 11:03:05silvansetmessages: + msg3841
2014-10-17 11:00:32maltesetmessages: + msg3840
2014-10-17 07:51:40silvansetmessages: + msg3839
2014-10-16 21:08:07silvansetmessages: + msg3838
2014-10-15 18:02:59silvancreate