Issue649

Title Get rid of g_rng() and --random-seed and use the functions in rng_options
Priority wish Status resolved
Superseder Nosy List jendrik, malte, silvan
Assigned To silvan Keywords
Optional summary

Created on 2016-04-21.17:03:16 by silvan, last changed by jendrik.

Messages
msg5938 (view) Author: jendrik Date: 2016-12-20.15:44:17
Mea culpa, I wasn't on the most recent revision.
msg5936 (view) Author: silvan Date: 2016-12-20.15:15:25
I can't reproduce this (I actually checked it before merging). Did you recompile
on the up-to-date default version?
msg5934 (view) Author: jendrik Date: 2016-12-20.14:53:49
--random-seed still appears in the --help output. I suggest grepping for it.
msg5922 (view) Author: silvan Date: 2016-12-20.12:40:15
Merged and pushed.
msg5920 (view) Author: silvan Date: 2016-12-20.11:36:32
Not sure if I wanted, but I did (of course after running the test locally and
fixing everything :-) ).
msg5914 (view) Author: jendrik Date: 2016-12-19.21:03:06
I left a few comments on bitbucket. The code looks good to me. Do you want to 
enable pipelines for this repo to see if all tests pass and all standard configs 
still run?
msg5909 (view) Author: silvan Date: 2016-12-19.19:08:31
I prepared a pull-request here:
https://bitbucket.org/SilvanS/fd-dev/pull-requests/24/issue649/diff

No experiments have been setup yet, because I'm not sure if that is necessary,
after a code review. After all, the "global" RNG object now only lives somewhere
else than before. However, they could be a good safety-check (but would requires
some work to setup all the configurations...).
msg5256 (view) Author: silvan Date: 2016-04-21.17:03:16
This is a follow up issue of issue648.

All current users of g_rng() should instead use the helper functions in
rng_options to add their own random_seed option and based on it get their
own/the global RNG object.
History
Date User Action Args
2016-12-20 15:44:17jendriksetmessages: + msg5938
2016-12-20 15:15:25silvansetmessages: + msg5936
2016-12-20 14:53:49jendriksetmessages: + msg5934
2016-12-20 12:40:15silvansetstatus: reviewing -> resolved
messages: + msg5922
2016-12-20 11:36:32silvansetmessages: + msg5920
2016-12-19 21:03:16jendriksetstatus: chatting -> reviewing
2016-12-19 21:03:06jendriksetmessages: + msg5914
2016-12-19 19:08:31silvansetmessages: + msg5909
2016-12-19 18:59:15silvansetassignedto: silvan
2016-04-21 17:03:16silvancreate