Issue710

Title Pattern Collection Generator Hill Climbing: refactoring
Priority feature Status resolved
Superseder Nosy List florian, jendrik, malte, silvan
Assigned To silvan Keywords
Optional summary

Created on 2017-03-07.14:12:21 by silvan, last changed by silvan.

Messages
msg6171 (view) Author: silvan Date: 2017-03-13.09:47:13
Done.
msg6170 (view) Author: jendrik Date: 2017-03-12.20:07:56
LGTM.
msg6169 (view) Author: malte Date: 2017-03-12.19:26:52
If you're all happy with it, feel free to merge.
msg6168 (view) Author: silvan Date: 2017-03-12.18:24:22
I also integrated the last comments from bitbucket. From my point of view, this
can be merged.
msg6167 (view) Author: silvan Date: 2017-03-10.16:18:34
Results look good (pretty much no changes):
http://ai.cs.unibas.ch/_tmp_files/sieverss/issue710-v1-issue710-base-issue710-v1-compare.html

I also addressed most of your comments, in particular writing a hopefully better
documentation for the hill climbing method.
msg6162 (view) Author: florian Date: 2017-03-08.10:17:39
I'm also done with my comments. And yes, I think the 2 ipdb configurations you
mentioned are a good test set.
msg6161 (view) Author: jendrik Date: 2017-03-07.19:18:47
I left some comments on BitBucket.
msg6160 (view) Author: silvan Date: 2017-03-07.15:01:01
I saw that two PDB specialists put themselves onto the nosy list :-) Who is up
for a review? It's not too large:
https://bitbucket.org/SilvanS/fd-dev/pull-requests/25/issue710/diff

I'll also setup some experiments; I assume running "astar(ipdb())" and
"astar(ipdb(max_time=900))" is enough?
msg6159 (view) Author: silvan Date: 2017-03-07.14:12:21
When working with the hill climbing generator, I (again) stumbled across some
subtleties and decided to open this issue for a few simplifications. For
instance, I'd like to get rid of keeping both the candidate patterns and the
PDBs around in parallel, rather than just keeping the PDBs from the beginning
on. After all, we can still access the patterns from the PDBs.
History
Date User Action Args
2017-03-13 09:47:13silvansetstatus: in-progress -> resolved
messages: + msg6171
2017-03-12 20:07:56jendriksetmessages: + msg6170
2017-03-12 19:26:52maltesetmessages: + msg6169
summary: If you're all happy with it, feel free to merge. ->
2017-03-12 19:26:40maltesetsummary: If you're all happy with it, feel free to merge.
2017-03-12 18:24:22silvansetstatus: chatting -> in-progress
messages: + msg6168
2017-03-10 16:18:34silvansetmessages: + msg6167
2017-03-08 10:17:39floriansetmessages: + msg6162
2017-03-07 19:18:47jendriksetmessages: + msg6161
2017-03-07 15:01:01silvansetmessages: + msg6160
2017-03-07 14:41:58floriansetnosy: + florian
2017-03-07 14:23:55jendriksetnosy: + jendrik
2017-03-07 14:12:21silvancreate