Issue723

Title move iterators from PerStateInformation to StateRegistry
Priority feature Status resolved
Superseder Nosy List florian, malte
Assigned To malte Keywords
Optional summary

Created on 2017-04-28.15:23:13 by malte, last changed by malte.

Messages
msg6293 (view) Author: malte Date: 2017-04-29.00:14:48
Merged and the buildbot is still green.
msg6292 (view) Author: florian Date: 2017-04-28.23:36:40
Yes. I think the buildbot should be fine. As you said, the iterator didn't
support the full interface before.
msg6291 (view) Author: malte Date: 2017-04-28.22:58:57
Thanks for the review! I've pushed a new version with the changes we discussed
and a merge from default. Should we try merging this version and see what the
buildbots make of it?
msg6280 (view) Author: florian Date: 2017-04-28.19:02:37
We discussed this offline. Just for the record, we discussed that the iterator
does not fully implement the interface of a forward iterator but that wasn't the
case before either. We decided to leave it until it causes a problem, document
it with a comment, and remove another unused increment operator.
msg6273 (view) Author: malte Date: 2017-04-28.16:13:34
Florian, I've created a pull request for you to review:

https://bitbucket.org/malte/downward/pull-requests/6/issue723/diff

Because the main code moved between different files, it is perhaps easiest to
look at the individual commits instead. For the commit where the files were
moved, the only changes in the iterator class were that the references to the
PerStateInformation disappeared. I think it would be fine not to review this
(because the move between files makes the diff annoying).
msg6272 (view) Author: malte Date: 2017-04-28.15:23:13
PerStateInformation currently has const iteration facilities (begin/end), but
they don't actually iterate over the per-state information, but only about the
states of a registry. We want to move this facility to the state registry instead.
History
Date User Action Args
2017-04-29 00:14:48maltesetstatus: reviewing -> resolved
messages: + msg6293
2017-04-28 23:36:40floriansetmessages: + msg6292
2017-04-28 22:58:57maltesetmessages: + msg6291
2017-04-28 19:02:37floriansetmessages: + msg6280
2017-04-28 16:13:40maltesetstatus: chatting -> reviewing
2017-04-28 16:13:34maltesetmessages: + msg6273
2017-04-28 15:23:13maltecreate