Issue882

Title Run Bitbucket pipelines only for branches with active pull requests
Priority wish Status resolved
Superseder Nosy List florian, jendrik, malte, silvan
Assigned To jendrik Keywords
Optional summary

Created on 2018-12-18.14:54:37 by jendrik, last changed by jendrik.

Messages
msg8415 (view) Author: jendrik Date: 2018-12-23.09:25:48
Thanks for the feedback! This is now merged.
msg8401 (view) Author: florian Date: 2018-12-20.10:44:07
I also don't use the pipelines and have no objection to merging this.
msg8390 (view) Author: silvan Date: 2018-12-18.16:12:22
Then I'm fine with this change; like Malte, I don't actively use the pipelines.
(I like the reminder to run uncrustify and code tests before the final merging,
though.)
msg8388 (view) Author: jendrik Date: 2018-12-18.15:20:33
Exactly.
msg8386 (view) Author: silvan Date: 2018-12-18.15:19:38
> Bitbucket would merge the default branch into the issue branch before running
the tests.
But it wouldn't commit that merge; this would be for testing only, right?
msg8385 (view) Author: malte Date: 2018-12-18.15:12:58
I don't really have a stake in the bitbucket pipelines, so I am not the right
person to review this.

If none of the others complains (given some time to react), perhaps you can
assume that everyone is fine with it. If you want to speed things up, perhaps
directly ask those who use this feature more actively.
msg8383 (view) Author: jendrik Date: 2018-12-18.15:02:53
It seems the new feature is already working nicely: no build was triggered when
I pushed the new branch, but it immediately started when I made the pull request.
msg8382 (view) Author: jendrik Date: 2018-12-18.15:01:33
I made a pull request at 
https://bitbucket.org/jendrikseipp/downward/pull-requests/115 .

The diff only changes three words, but the YAML file needs two extra spaces of
indentation now.
msg8381 (view) Author: jendrik Date: 2018-12-18.14:54:36
We currently run the Bitbucket pipelines for each newly pushed head revision.
This means that Bitbucket runs tests for pushes to the default branch, feature
branches that may never end up in the master repo (e.g., for papers), and even
commits that close branches (even if the branch was developed by others). Due to
all these build triggers, I usually run out of the 500 free build minutes per
month after around 10 days (each run takes 10-15 minutes). To use the free build
minutes for testing things we are actually interested in, I propose to use a new
Bitbucket pipelines feature: builds for pull requests 
(https://confluence.atlassian.com/bitbucket/configure-bitbucket-pipelines-yml-792298910.html#Configurebitbucket-pipelines.yml-ci_pull-requests).

The new setup would run the pipelines only for head revisions on branches that
have an active pull request. Also, in contrast to the current setup, Bitbucket
would merge the default branch into the issue branch before running the tests.
This would give us convenient warnings whenever a pull request needs updating
because of a failing automatic merge.
History
Date User Action Args
2018-12-23 09:25:48jendriksetstatus: reviewing -> resolved
messages: + msg8415
2018-12-20 10:44:07floriansetnosy: + florian
messages: + msg8401
2018-12-18 16:12:22silvansetmessages: + msg8390
2018-12-18 15:20:33jendriksetmessages: + msg8388
2018-12-18 15:19:38silvansetnosy: + silvan
messages: + msg8386
2018-12-18 15:12:58maltesetmessages: + msg8385
2018-12-18 15:02:53jendriksetmessages: + msg8383
2018-12-18 15:01:34jendriksetstatus: in-progress -> reviewing
messages: + msg8382
2018-12-18 14:54:37jendrikcreate