Issue896

Title Clean-up and make output/timing of pattern (collection) generators consistent
Priority feature Status resolved
Superseder Nosy List florian, jendrik, malte, silvan
Assigned To silvan Keywords
Optional summary

Created on 2019-02-27.14:53:20 by silvan, last changed by silvan.

Files
File name Uploaded Type Edit Remove
log-files.tar.gz silvan, 2019-02-27.17:11:06 application/gzip
Messages
msg8637 (view) Author: silvan Date: 2019-03-08.09:26:15
Thanks, merged.
msg8635 (view) Author: jendrik Date: 2019-03-07.23:17:55
Yes, they do :-)
msg8634 (view) Author: silvan Date: 2019-03-07.21:51:05
Thanks! Jendrik, do you want to check the latest two commits to see if they
achieve what you wanted?
msg8629 (view) Author: malte Date: 2019-03-07.18:10:44
I only had a fairly brief look, but from my side this looks good to merge.
msg8628 (view) Author: silvan Date: 2019-03-07.17:05:47
As discussed today, I added a TODO to the CPDB heuristic and simplified dumping
pattern collections computed by generators. Anyone can please have a final look?
msg8563 (view) Author: silvan Date: 2019-03-01.12:41:45
I took the comments, but couldn't resolve one of them. Other than that, happy
for another review.
msg8562 (view) Author: jendrik Date: 2019-02-27.23:18:40
I can have a look at the code once you're done taking or leaving the comments,
Silvan :-)
msg8558 (view) Author: malte Date: 2019-02-27.19:00:49
Sound like a laudable goal. I left some comments, but I don't want to be overly
picky with this, so please take or leave the comments. I'm happy to merge if
Florian and Jendrik are.
msg8557 (view) Author: silvan Date: 2019-02-27.17:11:06
I prepared a pull request:
https://bitbucket.org/SilvanS/fd-dev/pull-requests/45/issue896/diff

To see the effect, also find attached in log-files.tar.gz the log files of all
pattern (collection) generators.
msg8555 (view) Author: silvan Date: 2019-02-27.14:53:20
Working with pattern (collection) generators and the PDB codebase more
generally, I realized that we currently dump things like computation time of
various methods inconsistently (and duplicated, sometimes) at different places.
I'd like to consolidate the output.
History
Date User Action Args
2019-03-08 09:26:15silvansetstatus: reviewing -> resolved
messages: + msg8637
2019-03-07 23:17:55jendriksetmessages: + msg8635
2019-03-07 21:51:05silvansetmessages: + msg8634
2019-03-07 18:10:44maltesetmessages: + msg8629
2019-03-07 17:05:47silvansetmessages: + msg8628
2019-03-01 12:41:45silvansetmessages: + msg8563
2019-02-27 23:18:40jendriksetmessages: + msg8562
2019-02-27 19:00:49maltesetmessages: + msg8558
2019-02-27 17:11:06silvansetstatus: in-progress -> reviewing
files: + log-files.tar.gz
messages: + msg8557
2019-02-27 14:53:20silvancreate