> I suggest to do the renaming separately to keep the diff small.
I don't think it would be hard to review, and if it can be easily avoided, an
issue should not leave the default branch in a broken state. I think a
combination of "format_paper_reference" and "format_journal_article_reference"
is a (mildly) broken interface because it's an inconsistent level of
abstraction. (A journal article reference is a paper reference.)
Regarding the name, "journal article" is a better word in isolation, but
"journal paper" is sufficiently common, and it's good to have parallel names for
parallel functions. Another option would be "format_conference_reference" and
"format_journal_reference". But I'm also fine with your names.
|