Issue920

Title add scripts for making code distributions
Priority feature Status resolved
Superseder Nosy List florian, guillem, jendrik, malte
Assigned To florian Keywords
Optional summary

Created on 2019-06-06.18:07:39 by florian, last changed by florian.

Messages
msg8873 (view) Author: florian Date: 2019-06-12.01:24:50
We did some more changes live and merged the issue.
msg8872 (view) Author: malte Date: 2019-06-11.13:19:14
In case this has not been incorporated yet: we discussed in the live meeting
that we should not update the version number of the default branch on a bugfix
release.
msg8871 (view) Author: guillem Date: 2019-06-11.12:27:47
I'm doing that now
msg8870 (view) Author: malte Date: 2019-06-11.12:26:17
Sounds good to me. Who updates the wiki documentation?
msg8869 (view) Author: guillem Date: 2019-06-11.12:17:21
I had a look and tested as much as the scripts as I could. Some things I couldn't test 
(e.g. to test the docker build, we'll need the release tag to be in the main 
repository), but things look good to me. 
I'd say let's merge this, if something doesn't work as expected, we just fix it =)
msg8867 (view) Author: florian Date: 2019-06-07.20:43:50
Thanks, Jendrik. However, we were able to replace the Python scripts by a few
lines of Bash (replacing ~200 lines of Python by <20 lines of Bash). I
simplified the workflow by automating some additional steps in two scripts. The
new workflow with these scripts would be:

1. Update to the revision you want to release
2. "./misc/release/prepare-release.sh 19.06.0" to create tags and recipe files
3. Verify all changes locally
4. "hg push" in the Fast Downward repository to push the tags
5. "misc/release/push-docker.sh 19.06" to push the docker images
6. "git push" in the repository containing the container recipe files
7. Create wiki page
8. Send announcement email

(I removed steps 2 and 3 from
http://www.fast-downward.org/ForDevelopers/ReleaseWorkflow because Malte
suggested to keep the Changelog up to date while working on the planner instead
of creating it when doing a release.)

The first script (prepare-release.sh) commits to the repositories but does not
push anything, so if there are any problems, we can still strip the new
revisions and try again. The second script (push-docker.sh) will build the
docker image, push it, and clean up temporary files. It will prompt the user for
credentials to dockerhub to do this (same as in step 11 of the old workflow).

Can someone review these changes?
msg8859 (view) Author: jendrik Date: 2019-06-07.09:45:54
I left some comments.
msg8857 (view) Author: florian Date: 2019-06-06.20:00:00
I created a pull request:
https://bitbucket.org/FlorianPommerening/downward-issues/pull-requests/56
msg8854 (view) Author: florian Date: 2019-06-06.18:07:39
In issue19 we came up with steps for creating an official code distribution. As
part of that, we want to create container setup recipes and set the version
number. In this issue, we want to add the created scripts to the misc directory.
Most steps are not automated so far but more complete automation will be a
separate issue.
History
Date User Action Args
2019-06-12 01:24:50floriansetstatus: reviewing -> resolved
messages: + msg8873
2019-06-11 13:19:14maltesetmessages: + msg8872
2019-06-11 12:27:47guillemsetmessages: + msg8871
2019-06-11 12:26:18maltesetmessages: + msg8870
2019-06-11 12:17:21guillemsetmessages: + msg8869
2019-06-07 20:43:50floriansetstatus: in-progress -> reviewing
messages: + msg8867
2019-06-07 09:45:54jendriksetmessages: + msg8859
2019-06-06 20:00:00floriansetmessages: + msg8857
2019-06-06 18:07:39floriancreate