Issue622

Title Read build configurations from file
Priority feature Status resolved
Superseder Nosy List florian, jendrik, malte, silvan
Assigned To florian Keywords
Optional summary

Created on 2016-01-08.17:34:05 by florian, last changed by florian.

Messages
msg5087 (view) Author: florian Date: 2016-01-14.17:39:53
Merged. Thanks for the reviews.
msg5086 (view) Author: malte Date: 2016-01-14.16:57:03
Fine with me.
msg5085 (view) Author: florian Date: 2016-01-14.16:47:20
Can we merge this?
msg5065 (view) Author: florian Date: 2016-01-09.11:48:43
Ok. I updated the pull request.
msg5064 (view) Author: malte Date: 2016-01-08.23:23:21
Perhaps we should just make DEFAULT and DEBUG more special then and go with your
previous idea: make these variables to which config names are assigned, not configs.

DEFAULT = "release32"
DEBUG = "debug32"
msg5061 (view) Author: florian Date: 2016-01-08.21:56:12
Ahh, its not just the log message that changes from release32 to DEFAULT. The
name of the build directory also changes. This means that

  ./build.py && ./fast-downward.py --build=release32

will no longer work. This seems worse than I thought.
msg5060 (view) Author: florian Date: 2016-01-08.21:50:01
I prepared a pull request on bitbucket:
https://bitbucket.org/flogo/downward-issues/pull-requests/14/issue622/diff

One small disadvantage of the new way of storing default configs is that a call
to "./build.py" (without parameters) will now report "Building configuration
DEFAULT" instead of "Building configuration release32". Similarly a call to
"./build.py --debug" will report "Building configuration DEBUG" instead of
"Building configuration debug32". I think we can live with that, though.

Malte, could you have a look (doesn't have to be on the weekend, of course)?

https://bitbucket.org/flogo/downward-issues/pull-requests/14/issue622/diff
msg5054 (view) Author: florian Date: 2016-01-08.17:37:44
I also want to add a new alias "minimal" that only contains the planner core and
otherwise is like release32.
msg5053 (view) Author: florian Date: 2016-01-08.17:34:05
The build configurations ("release32", "debug32", etc.) are currently defined in
build.py. We want to move them to a separate file. Additionally, we want that
all files with names that match a certain pattern are read in, so its possible
to define temporary files with build configurations. For example, this could be
done for an experiment within an issue branch.

We briefly talked about the naming patterns after the meeting and suggest to use
all files "*build_configs.py" in the repository root. The default configs would
be in build_configs.py and custom configs could be in
"issue622_build_configs.py" or "my_custom_build_configs.py".

For now we just want to look in the repository root directory, but we could
later also add other paths like the home directory for global configs.
History
Date User Action Args
2016-01-14 17:39:53floriansetstatus: chatting -> resolved
messages: + msg5087
2016-01-14 16:57:03maltesetmessages: + msg5086
2016-01-14 16:47:20floriansetmessages: + msg5085
2016-01-09 11:48:43floriansetmessages: + msg5065
2016-01-08 23:23:21maltesetmessages: + msg5064
2016-01-08 21:56:12floriansetmessages: + msg5061
2016-01-08 21:50:01floriansetmessages: + msg5060
2016-01-08 17:37:44floriansetmessages: + msg5054
2016-01-08 17:34:51silvansetnosy: + silvan
2016-01-08 17:34:05floriancreate